LS: Make FileDiagnostics use URLs exclusively to survive db swaps
#6681
+20
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
requested review from
orizi,
Arcticae,
Draggu and
piotmag769
as code owners
This was referenced Nov 18, 2024
|
This change is |
piotmag769
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @orizi)
Draggu
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
Arcticae
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Reviewable status:
orizi
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status:
mkaput
force-pushed
the
spr/main/38130ae5
branch
2 times, most recently
from
57abdc2
to
195145c
Compare
mkaput
force-pushed
the
spr/main/8a3daf09
branch
from
b1f0022
to
d34acf7
Compare
mkaput
force-pushed
the
spr/main/38130ae5
branch
from
195145c
to
7af1344
Compare
commit-id:38130ae5
mkaput
force-pushed
the
spr/main/38130ae5
branch
from
7af1344
to
d11c388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.